Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use a separate covector workflor for 1.x #7243

Merged
merged 1 commit into from
Jun 18, 2023
Merged

chore(ci): use a separate covector workflor for 1.x #7243

merged 1 commit into from
Jun 18, 2023
+151 −3

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog
Copy link
Member Author

Using a dedicated workflow for 1.x prevents issues when merging 1.x back into dev.

amrbashir
amrbashir reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't think we should be merging 1.x back to dev, they are different branches now, that will have their own history, any changes should be backported to 1.x manually and in its own PR IMO.

@lucasfernog
Copy link
Member Author

We're still working on v1 kinda actively, so cherry picking each PR is slow and polutes the pull requests tab 😢

amrbashir
amrbashir approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, I guess we could keep it that way for now

@lucasfernog lucasfernog merged commit fdf6840 into 1.x Jun 18, 2023
@lucasfernog lucasfernog deleted the chore/separate-covector-workflow branch June 18, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasfernog @amrbashir